Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portage Template not default/first template #685

Closed
closenma opened this issue Mar 6, 2024 · 2 comments
Closed

Portage Template not default/first template #685

closenma opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@closenma
Copy link
Collaborator

closenma commented Mar 6, 2024

Please complete the following fields as applicable:

User reports that the list appears out of order, and that historically Portage Template was first/default. This is also indicated on https://dmp-pgd.ca/about_us

This appears to be the case for my own account in the U of A org (screenshot here)
Screenshot 2024-03-06 at 11 56 09 AM

Rather than the standard Portage Template, CRDCN template is showing up first (alphabetical order)

@closenma closenma added the bug Something isn't working label Mar 6, 2024
@lagoan
Copy link
Collaborator

lagoan commented Mar 18, 2024

The template selection drop down should have a specific order. The following is the order we used in the past:

  • First the default template (Portage Template)
  • The rest of the default organizations (Portage) templates
  • The users own organizations templates

If an organization administrator customizes a template, then the customized template should now appear and not the original template.

For example.

The original list is:

  • Portage Template
  • Portage Template for Systematic Reviews
  • Portage Template for Water Quality Research
  • University of Alberta Template

Then an administrator from the University of Alberta customizes "Portage Template for Water Quality Research", The list will seem the same, but selecting "Portage Template for Water Quality Research" will take the user to that cusomized template.

  • Portage Template
  • Portage Template for Systematic Reviews
  • Portage Template for Water Quality Research (Same title but now it directs to the customized version)
  • University of Alberta Template

@aaronskiba
Copy link
Collaborator

It looks like the sorting is disregarding both the default template as well as the default organisation:
Screenshot from 2024-03-27 13-19-51

aaronskiba added a commit that referenced this issue Mar 27, 2024
Prior to this commit, all of the templates were simply being sorted by title.

Now, the sorting follows the instructions specified within the following GitHub issue comment: #685 (comment)
aaronskiba added a commit that referenced this issue Mar 27, 2024
Prior to this commit, all of the templates were simply being sorted by title.

Now, the sorting follows the instructions specified within the following GitHub issue comment: #685 (comment)
aaronskiba added a commit that referenced this issue Mar 28, 2024
Prior to this commit, all of the templates were simply being sorted by title.

Now, the sorting follows the instructions specified within the following GitHub issue comment: #685 (comment)
aaronskiba added a commit that referenced this issue Apr 8, 2024
Prior to this commit, all of the templates were simply being sorted by title.

Now, the sorting follows the instructions specified within the following GitHub issue comment: #685 (comment)
aaronskiba added a commit that referenced this issue Apr 10, 2024
Commit d127444 implemented the template sorting as described here: #685

However, the fix did not address the template sorting when "No research organization associated with this plan or my research organization is not listed" is checked. This commit does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants