Fix WebDrivers For Chrome v116+ #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e9dac51.
"If you cannot upgrade to Selenium 4.11, Webdrivers 5.3.0 will continue to support Ruby 2.6+ and Selenium 4.0 - 4.10" - https://github.com/titusfortner/webdrivers
-Needed for webdrivers to work with Chrome v116+
lagoan
reviewed
Aug 25, 2023
| WebMock.disable_net_connect!( | ||
| allow_localhost: true, | ||
| allow: %w[chromedriver.storage.googleapis.com] | ||
| allow: %w[chromedriver.storage.googleapis.com googlechromelabs.github.io edgedl.me.gvt1.com] |
There was a problem hiding this comment.
Will we need to revert this change once we upgrade to ruby 3?
There was a problem hiding this comment.
When we upgrade to Ruby 3, I'm thinking we should upgrade to Selenium 4.11+.
According to https://github.com/titusfortner/webdrivers:
"If you can update to the latest version of Selenium (4.11+), please do so and stop requiring this gem."
I'm not sure if Selenium will need googlechromelabs.github.io and edgedl.me.gvt1.com.
There was a problem hiding this comment.
Sounds great!
@aaronskiba please add a ticket so we don't forget to follow the suggestions after the upgrade to ruby 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the rspec test failures due to the incompatibility between Webdrivers 5.2 and Chrome 116+.