Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Rollbar Gem To Enable Tracking on rollbar.com #687

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

aaronskiba
Copy link
Collaborator

Fixes #686

Changes proposed in this PR:

  • This change enables app errors to be sent to rollbar.com. This is achieved by editing the gem 'rollbar' config within Gemfile.
  1. Remove group: :rollbar
    config/initializers/rollbar.rb includes the following line:
config.enabled = false if Rails.env.test?

Thus, simply having the gem as part of the :default group should be okay.

  1. Remove required: :false
    rake rollbar:test can be executed to send a test message to rollbar.com. However, this rake task doesn't work when require: false is part of the gem 'rollbar' config.

This change enables app errors to be sent to rollbar.com

`config/initializers/rollbar.rb` includes the following line:
`config.enabled = false if Rails.env.test?`
Thus, having the gem as part of the :default group should be okay.

`rake rollbar:test` can be executed to send a test message to rollbar.com. However, this rake task doesn't work when `require: false` is part of the gem 'rollbar' config.
Copy link
Collaborator

@200455939-yashu 200455939-yashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 👏

Copy link
Collaborator

@lagoan lagoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronskiba aaronskiba merged commit 0687420 into integration Apr 8, 2024
13 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/686 branch April 8, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants