Fix/Re-Enable Some RSpec Features Tests #798
Open
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronskiba
commented
Jul 3, 2024
aaronskiba
force-pushed
the
aaron/issues/797
branch
from
07504e9 to
6000715
Compare
aaronskiba
force-pushed
the
aaron/issues/797
branch
2 times, most recently
from
6457d5a to
8da2461
Compare
The "Create Plan UI" For DMP Assistant diverges from that of DMP Roadmap. This commit adapts the tests within `spec/features/plans_spec.rb` to work with DMP Assistant's UI and logic.
Copy/paste same file from DMP Roadmap
This commit adapts commit da3a9ed to DMP Assistant. - When selecting a locale, a corresponding `dmp_logo_XX.png` file must be present within the asset pipeline. If the .png file does not exist, an error is encountered. For example, the following is encountered when `click_link 'German'` is executed within this test: ``` Failure/Error: <%= link_to(image_tag(current_locale_logo, ActionView::Template::Error: The asset "dmp_logo_de.png" is not present in the asset pipeline. ``` Thus, this file has been modified to only include the available locales within DMP Assistant.
The 'User creates a new Plan' test will not pass unless an org exists within the db such that `org.id == Rails.application.config.default_funder_id`. However, we have `config.default_funder_id = Rails.application.secrets.default_funder_id` within `config/application.rb`. This secret is not read while executing the tests via our GitHub actions. Thus, we are overriding/setting that value within the test itself.
aaronskiba
force-pushed
the
aaron/issues/797
branch
from
8da2461 to
8e90edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #797
Changes proposed in this PR:
spec/features/plans_spec.rb) was previously skipped. Although, it is working for DMPRoadmap, it was not compatible with DMP Assistant. This PR edits the test (specifically regarding "default funder" handling, as well as the differences in the UI of the/plans/newpage) to make it work with DMP Assistant.spec/features/locales_spec.rbwere also previously skipped. When selecting a locale, there must be a correspondingdmp_logo_XX.pngwithin the asset pipeline, where "XX" corresponds with the locale's abbreviation. This PR edits the locales within this file to only ones where there is a correspondingdmp_logo_XX.pngfile within the asset pipeline.