Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto scroll the name list #2358

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Nov 14, 2024

  • scroll per sec (maybe not that very accuracy but doesn't matter)
  • when user interact, disable scroll

@zxkmm zxkmm marked this pull request as ready for review November 14, 2024 09:23
@zxkmm zxkmm enabled auto-merge (squash) November 14, 2024 09:24
@zxkmm zxkmm requested review from gullradriel and htotoo November 14, 2024 09:26
@eried
Copy link
Member

eried commented Nov 14, 2024

Very cool improvement 😁

...in my mind, this "about_simple" was gonna be a very temporal file. We should discuss about making an "about_fancier" 😐 considering contributors have made so many new features lately, it could be a game with contributors names

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

I want a Matrix style digits flow screensaver. Maybe HTotoo can do it🫣

@eried
Copy link
Member

eried commented Nov 14, 2024

I want a Matrix style digits flow screensaver. Maybe HTotoo can do it🫣

But interactive? @htotoo 🤔

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

But interactive?

he did it already but not with contributor's name, instead of random digits

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

no interactive yet

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

but why interactive in about page tho? XD

@eried
Copy link
Member

eried commented Nov 14, 2024

but why interactive in about page tho? XD

Imagine is the Windows 95 maze screensaver but with the names on the walls :P autoroams by default but can be controlled. Small section in the maze with "chinatown" for you

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

lemme search the maze screensaver and i'll see if im able to do it, after this merged XD

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

ahhhh it's 3D. i don't think i can do 3D XD

@gullradriel
Copy link
Member

Jokes aside, tested and works.
If possible I would like the list to have focus if rotary encoder is used, so using it does not only stop the autoscroll, but also allow to crawl in the list without the need to use "up" before.
As talked in discord, the "OK" button can keep the focus unless there is a rotary encoder used.

Copy link
Member

@gullradriel gullradriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@zxkmm zxkmm merged commit 6c83825 into portapack-mayhem:next Nov 14, 2024
3 checks passed
@htotoo
Copy link
Member

htotoo commented Nov 14, 2024

You really wanna have the matrix one but with the names? :D

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

I want but idk if others agree

@zxkmm zxkmm deleted the auto_scroll_about branch November 14, 2024 16:40
@gullradriel
Copy link
Member

Well, I prefer radio related things than a matrix contributor list

@zxkmm
Copy link
Contributor Author

zxkmm commented Nov 14, 2024

@gullradriel github avatar checked out🤣

@gullradriel
Copy link
Member

I don't even remember where I steal it x-D

@htotoo
Copy link
Member

htotoo commented Nov 14, 2024

Maybe as a standalone app, and you can start it with a hidden about menu stuff, when it is on the sd card :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants