Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoder setting p.mem issue #2475

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Jan 9, 2025

  • Previously I misunderstood how p.mem works and it seems the default should be false.
  • removed useless enum and use bool, and use comment everywhere to indicate, because with enum there would be too many useless implicit cast and misleading people (I guess).

@zxkmm zxkmm marked this pull request as ready for review January 9, 2025 09:17
@gullradriel
Copy link
Member

Looks good.

@gullradriel gullradriel merged commit 7eb08f3 into portapack-mayhem:next Jan 9, 2025
3 checks passed
@zxkmm zxkmm deleted the encoder_3 branch January 11, 2025 03:44
@GoDHomer
Copy link

I just registered, maybe I'm writing in the wrong place. I installed this firmware, I really liked it, but I found something wrong. If you go to transmit > RDS and just click send, everything works, but if you change the text, an error often occurs.

@gullradriel
Copy link
Member

I just registered, maybe I'm writing in the wrong place. I installed this firmware, I really liked it, but I found something wrong. If you go to transmit > RDS and just click send, everything works, but if you change the text, an error often occurs.

Indeed, a closed Pull Request is not the place to ask for a question.
You may want to open a new issue and/or ask on Mayhem's discord, #question-and-help channel.

Anyway regarding your issue, I could not reproduce it on my device.

Please consider when opening your ticket to:

  • specify firmware version
  • provide a detailed step by step way to reproduce your crash
  • if on discord, provide a video showing the problem

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants