support target CLI #4465
Merged
support target CLI #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
d-g-town
commented
Mar 28, 2024
•
d-g-town
commented
stefanmcshane
approved these changes
Mar 28, 2024
ianedwards
approved these changes
Mar 28, 2024
| @@ -22,8 +22,13 @@ func (repo *DeploymentTargetRepository) DeploymentTargetBySelectorAndSelectorTyp | |||
| return nil, errors.New("cannot read database") | |||
| } | |||
|
|
|||
| // ListForCluster returns all deployment targets for a project | |||
| func (repo *DeploymentTargetRepository) ListForCluster(projectID uint, clusterID uint, preview bool) ([]*models.DeploymentTarget, error) { | |||
There was a problem hiding this comment.
would be nice to make cluster id and preview functional arguments
There was a problem hiding this comment.
for sure, will add
There was a problem hiding this comment.
actually the interface logic and gorm made this annoying: honestly the fix is to move this logic to CCP. Will do later
ferozemohideen
approved these changes
Mar 28, 2024
d-g-town
force-pushed
the
dgtown/support-target-cli
branch
from
13c48e1 to
eb48c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.