Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.0] [bugfix] - Manifest list not showing scroll #896

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

jnfrati
Copy link
Contributor

@jnfrati jnfrati commented Jul 15, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements:

  • If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
  • If it's a frontend change, Prettier has been run
  • Docs have been reviewed and added / updated if needed

What is the current behavior?

When the manifest list has too many items it's not scrollable

Closes #893

What is the new behavior?

The manifest list will display a scroll bar when there are too many items

Technical Spec/Implementation Notes

Added overflow-y: auto; to the manifest list wrapper so it'll show the scroll bar when necessary

@jnfrati jnfrati requested a review from sunguroku July 15, 2021 19:26
@jnfrati jnfrati self-assigned this Jul 15, 2021
@sunguroku sunguroku merged commit 814bffd into master Jul 15, 2021
@jnfrati jnfrati linked an issue Jul 22, 2021 that may be closed by this pull request
3 tasks
@abelanger5 abelanger5 deleted the 0.6.0-fix-893-manifiest-list-not-scrollable branch August 9, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s manifests not scrollable in "Manifests" tab k8s objects in the manifest tab are not scrollable
2 participants