Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.0] Turn off email verification if no email client #914

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

abelanger5
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Other (please describe): be able to turn off email verification for locally runnable + dev versions

Pull request checklist

Please check if your PR fulfills the following requirements:

  • If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
  • If it's a frontend change, Prettier has been run
  • Docs have been reviewed and added / updated if needed

What is the current behavior?

Email verification is always on.

What is the new behavior?

If there's no email client, turn email verification off.

Technical Spec/Implementation Notes

To test: remove email env variables and make sure new users don't require verification.

@abelanger5 abelanger5 merged commit d04087f into master Jul 23, 2021
@abelanger5 abelanger5 linked an issue Jul 26, 2021 that may be closed by this pull request
3 tasks
@abelanger5 abelanger5 deleted the 0.6.0-903-email-verification-config branch August 9, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email verification should be turned off for locally running instances
1 participant