Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows installer does not set DisplayVersion when registering the uninstaller #3016

Closed
l-c-g opened this issue Oct 27, 2022 · 4 comments
Closed

Windows installer does not set DisplayVersion when registering the uninstaller #3016

l-c-g opened this issue Oct 27, 2022 · 4 comments
Labels
bug

Comments

@l-c-g
Copy link
Contributor

l-c-g commented Oct 27, 2022

Describe the bug
Windows installer does not set DisplayVersion when registering the uninstaller. This is used by winget to determine the currently installed version and to compare it to the newest available version during winget upgrade. See ItzLevvie's comment on winget issue 1356.

To Reproduce
Steps to reproduce the behavior:

  1. Use the installer on Windows (or run winget install buchen.portfolio)
  2. Check in the registry for the DisplayVersion value in 'HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Portfolio Performance'
  3. Notice that there is no DisplayVersion value
  4. (Alternatively, wait for a new Portfolio Performance release and notice the warning during winget upgrade about unknown version numbers. Checking the registry is faster.)

Expected behavior
DisplayVersion should exist and contain the currently installed version of the application.

Desktop (please complete the following information):

  • Windows 11 22H2
  • Portfolio Performance 0.59.2
@l-c-g l-c-g added the bug label Oct 27, 2022
l-c-g added a commit to l-c-g/portfolio that referenced this issue Oct 27, 2022
@l-c-g
Set DisplayVersion in the uninstaller entry
a1eba6e 
This is used by winget to compare the installed version with the latest
online version to determine whether an update is available.

Issue: portfolio-performance#3016
@l-c-g l-c-g mentioned this issue Oct 27, 2022
Merged
@Morpheus1w3
Copy link
Contributor

Well, Portfolio Performance has a very well implemented self-update which checks every start, if the software is up to date. External update clients are omitted, as they have often have difficulties with Java compiled software.

@Morpheus1w3 Morpheus1w3 mentioned this issue Oct 27, 2022
Closed
buchen pushed a commit that referenced this issue Oct 30, 2022
@l-c-g @buchen
Set DisplayVersion in the uninstaller entry
fb5092f 
This is used by winget to compare the installed version with the latest
online version to determine whether an update is available.

Issue: #3016
@OnkelDok OnkelDok mentioned this issue Feb 23, 2023
Closed
@chirlu chirlu mentioned this issue Nov 19, 2023
Open
@CanePlayz
Copy link

@l-c-g The installer definition is located in portfolio-product/installer/installer.nsi. The version should be set in line 74 with this WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayVersion" "${SOFTWARE_VERSION}". Now, I don't know where this variable is coming from, but there seems to be an issue with it

@Morpheus1w3 Would there be anything you could do now with this new information?

@l-c-g
Copy link
Contributor Author

l-c-g commented Mar 2, 2024

@CanePlayz I know where this registry entry is set, I made the pull request that added the line.

In fact, when your comment came in, I was surprised to see this still open. @buchen had merged the code and my original issue with winget has been resolved ever since. I did not follow up on this issue after that but I am closing it now.

@l-c-g l-c-g closed this as completed Mar 2, 2024
@CanePlayz
Copy link

@l-c-g Ah, thanks for fixing it. I hadn't re-installed PP in quite a while so I didn't notice that it had been fixed, but it totally makes sense with the custom upgrade behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@l-c-g @CanePlayz @Morpheus1w3