Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From ws_objects #7

Merged
merged 2 commits into from
Mar 27, 2020
Merged

From ws_objects #7

merged 2 commits into from
Mar 27, 2020

Conversation

jacekkopecky
Copy link
Contributor

  • we should disallow use of backticks without need:
    let col = `crimson`; // bad, use single quotes
  • we should allow the lack of space between one-line class members:
    class Shape {
      #x; // it's ok not to have an empty line between #x and #y 
      #y;
    
      constructor(x, y) {
        
      }
    }

@jacekkopecky jacekkopecky requested a review from ear1grey March 26, 2020 17:52
@ear1grey ear1grey merged commit 78b5eba into master Mar 27, 2020
@ear1grey ear1grey deleted the from_ws_objects branch March 27, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants