In "go test" 1.13 and higher, you cannot call parse.Flags in init()

In https://golang.org/doc/go1.13#testing

    Testing flags are now registered in the new Init function,
    which is invoked by the generated main function for the test.
    As a result, testing flags are now only registered when running
    a test binary, and packages that call flag.Parse during package
    initialization may cause tests to fail.

See:
  https://groups.google.com/d/msg/golang-nuts/rkCdS1EQwSM/4gbwNh0QAwAJ
  golang/go#21051
  https://go-review.googlesource.com/c/go/+/173722/
  https://www.bountysource.com/issues/79987300-flag-provided-but-not-defined-test-timeout-go-1-13
  https://golang.org/pkg/testing/#hdr-Main

Makefile

@@ -14,6 +14,7 @@ TAGS := daemon
 endif
 
 ifndef PKGS
+# shell does not honor export command above, so we need to explicitly pass GOFLAGS here
 PKGS := $(shell GOFLAGS=-mod=vendor go list ./... 2>&1 | grep -v 'github.com/portworx/torpedo/tests')
 endif
 

tests/asg/asg_test.go

@@ -3,6 +3,7 @@ package tests
 import (
 	"fmt"
 	"math/rand"
+	"os"
 	"testing"
 	"time"
 
@@ -203,8 +204,10 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }
 
 func Scale(count int64) {

tests/autopilot/autopilot_test.go

@@ -2,6 +2,7 @@ package tests
 
 import (
 	"fmt"
+	"os"
 	"strings"
 	"testing"
 	"time"
@@ -525,6 +526,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/basic/basic_test.go

@@ -3,6 +3,7 @@ package tests
 import (
 	"fmt"
 	"math/rand"
+	"os"
 	"testing"
 	"time"
 
@@ -444,6 +445,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/drive_failure/drive_failure_test.go

@@ -2,6 +2,7 @@ package tests
 
 import (
 	"fmt"
+	"os"
 	"testing"
 	"time"
 
@@ -122,6 +123,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/node_decommission/node_decommission_test.go

@@ -3,6 +3,7 @@ package tests
 import (
 	"fmt"
 	"math/rand"
+	"os"
 	"testing"
 	"time"
 
@@ -121,6 +122,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/reboot/reboot_test.go

@@ -2,6 +2,7 @@ package tests
 
 import (
 	"fmt"
+	"os"
 	"testing"
 	"time"
 
@@ -160,6 +161,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/sched/sched_test.go

@@ -2,6 +2,7 @@ package tests
 
 import (
 	"fmt"
+	"os"
 	"testing"
 	"time"
 
@@ -83,6 +84,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/upgrade/upgrade_test.go

@@ -2,6 +2,7 @@ package tests
 
 import (
 	"fmt"
+	"os"
 	"strings"
 	"testing"
 
@@ -116,6 +117,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }

tests/volume_ops/volume_ops_test.go

@@ -3,6 +3,7 @@ package tests
 import (
 	"fmt"
 	"math"
+	"os"
 	"testing"
 
 	. "github.com/onsi/ginkgo"
@@ -167,6 +168,8 @@ var _ = AfterSuite(func() {
 	ValidateCleanup()
 })
 
-func init() {
+func TestMain(m *testing.M) {
+	// call flag.Parse() here if TestMain uses flags
 	ParseFlags()
+	os.Exit(m.Run())
 }