Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive explorer #45

Merged
merged 61 commits into from
Sep 28, 2023
Merged

Archive explorer #45

merged 61 commits into from
Sep 28, 2023

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Jul 14, 2023

Development branch for the archive explorer.

@stschiff
Copy link
Member

Is this ready for review? And how does this branch and PR relate to the other explorer branches?

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it out locally and I'm happy with this PR.

@nevrome
Copy link
Member Author

nevrome commented Jul 17, 2023

Sorry for the late reply, but this is not meant for merging yet. This is @dhananjaya93's dev branch. Dhana had some trouble setting this up, so we went through it together. I'll make it a draft PR. Sorry again for wasting your time.

@nevrome nevrome marked this pull request as draft July 17, 2023 08:26
@stschiff
Copy link
Member

Hi Dana. OK, so I've looked at this. I am not sure I fully understand the UI just yet.

  • I see that the user can choose between "Table View" and "List View", but what's the purpose of the "List view"?
  • The "Map View" appears empty right now. I see a world map, but no individuals on it, even if I select a package
  • I don't fully understand what the "Show Selection" button does.
  • Below the table, it always says "...fetching data from poseidon package server", even if the table is already there.
  • I like the search bar, which works very snappy... but I don't fully understand what is being searched. For example, if I input "schiffels", among other packages I get to see 2014_LazaridisNature, which I wasn't part of... (but perhaps I am listed as maintainer or something?)
  • I think we commented already somewhere else that we would like the table to be a bit tidier, so basically listing the title, the description, and then perhaps a single column joining Version, last-modified, Poseidon-Version and Individuals for better overview.

Happy to discuss more on Friday.

@stschiff
Copy link
Member

stschiff commented Aug 25, 2023

Additional comments from Meeting on Aug 25:

  • List view not necessary ATM
  • Table view -> perhaps some interactivity. Ideas:
    • Download link
    • Button to highlight samples from this package in the map
    • Perhaps for the future: List individual/group information or janno content for a specific package. Perhaps as a pop-up, or an expanding view.
    • In the map view: For an individual, show also group and age and location, and perhaps a button to scroll to the related package information in the table.
    • In general, perhaps change the table to a list of cards or something, which could be more flexible when we want to expand a specific card or so.

Perhaps we should change the

@nevrome nevrome marked this pull request as ready for review September 28, 2023 12:06
@nevrome nevrome merged commit 23bbdfb into master Sep 28, 2023
@nevrome nevrome deleted the repo_ex3 branch September 28, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants