Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default gopath $HOME/go when env var $GOPATH is not set. #45

Merged
merged 1 commit into from
Jul 30, 2017

Conversation

Deleplace
Copy link
Contributor

See golang/go#17262 about the implicit default gopath.

Also, this fixes the tests and "might" work better on Windows with multiple gopath entries (not thoroughly test by me yet).

@codecov
Copy link

codecov bot commented Jul 30, 2017

Codecov Report

Merging #45 into master will decrease coverage by 0.77%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   92.55%   91.77%   -0.78%     
==========================================
  Files          14       14              
  Lines         658      669      +11     
==========================================
+ Hits          609      614       +5     
- Misses         37       42       +5     
- Partials       12       13       +1
Impacted Files Coverage Δ
gocomplete/pkgs.go 73.77% <50%> (-6.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c111db7...4bd1bbc. Read the comment docs.

@Deleplace
Copy link
Contributor Author

Deleplace commented Jul 30, 2017

I'm not sure about the coverage warnings. Maybe due to half of the findGopath body never being executed on the codecov side?
I guess we can raise the coverage numbers by artificially tweaking the environment variables at runtime during tests (I have never done this, yet).
Tweaking the environment variables during tests may unfortunately jeopardize the t.Parallel() thing.

@posener
Copy link
Owner

posener commented Jul 30, 2017

I just keep the codecov warnings to know when a change is not covered, but I think that in this case we can accept it :-)

@posener
Copy link
Owner

posener commented Jul 30, 2017

Thanks for the fixes!

@posener posener closed this Jul 30, 2017
@posener posener reopened this Jul 30, 2017
@posener posener merged commit f4461a5 into posener:master Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants