Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -render-type-content option to render full type content instead of an ellipsis ({ ... }) #129

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

alexandregv
Copy link
Contributor

@alexandregv alexandregv commented Mar 18, 2024

Adds a -render-type-content bool flag which allows to control wether you want to replace types content with an ellipsis or not.
It defaults to false, to keep the current behavior.

Example with -render-type-content=true:

type Config struct { ... }

becomes

type Config struct {
    Username      string `json:"username"`
    Password      string `json:"password"`
}

@alexandregv alexandregv mentioned this pull request Mar 18, 2024
cmd/goreadme/main.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.87%. Comparing base (8283e66) to head (1ef7e79).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files           3        3           
  Lines          83       83           
=======================================
  Hits           58       58           
  Misses         15       15           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posener
Copy link
Owner

posener commented Mar 25, 2024

Maybe add a test? Also update pr text? Thanks!

@alexandregv alexandregv changed the title Add -ellipsis option to enable/disable ellipsis ({ ... }) Add -render-type-content option to enable/disable ellipsis ({ ... }) Mar 26, 2024
@alexandregv alexandregv changed the title Add -render-type-content option to enable/disable ellipsis ({ ... }) Add -render-type-content option to render full type content of an ellipsis ({ ... }) Mar 26, 2024
@alexandregv alexandregv changed the title Add -render-type-content option to render full type content of an ellipsis ({ ... }) Add -render-type-content option to render full type content instead of an ellipsis ({ ... }) Mar 26, 2024
@alexandregv
Copy link
Contributor Author

alexandregv commented Mar 26, 2024

Just added a test, and changed PR text.

@posener posener merged commit 92aad77 into posener:master Apr 3, 2024
3 of 5 checks passed
@alexandregv alexandregv deleted the no_ellipsis branch April 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants