Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type regex to include multi-line curly brackets #96

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Fix type regex to include multi-line curly brackets #96

merged 8 commits into from
Oct 29, 2020

Conversation

romainbou
Copy link
Contributor

The previous regex had two issues:

  • Failed to match when the [] where in the brackets
  • Failed to match when the content in the brackets had a line break.

@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited
Loading

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   69.51%   69.51%           
=======================================
  Files           3        3           
  Lines          82       82           
=======================================
  Hits           57       57           
  Misses         15       15           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5f314...be67bd2. Read the comment docs.

posener
posener reviewed Oct 21, 2020
View reviewed changes
Copy link
Owner

@posener posener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Maybe add this case to the test?

posener
posener reviewed Oct 29, 2020
View reviewed changes
README.md Outdated
@@ -1,8 +1,8 @@
# goreadme

[![Build Status](https://travis-ci.org/posener/goreadme.svg?branch=master)](https://travis-ci.org/posener/goreadme)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha thanks, that was not intentional!
The side effects of having GitHub Actions automatically updating READMEs! 😅

@posener posener merged commit 7e9b8ca into posener:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posener posener posener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romainbou @posener