Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LSP's tokio::Runtime and Client to RMain #193

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Move LSP's tokio::Runtime and Client to RMain #193

merged 8 commits into from
Jan 8, 2024

Commits on Jan 8, 2024

  1. Hack away enough to get a runtime global

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    eb510bc View commit details
    Browse the repository at this point in the history

  2. Recognize that enqueue_diagnostics() isn't async

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    20210cc View commit details
    Browse the repository at this point in the history

  3. Use non-blocking spawn() to avoid deadlocking R

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    1e92bf7 View commit details
    Browse the repository at this point in the history

  4. Let start_kernel() own the runtime

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    20c9529 View commit details
    Browse the repository at this point in the history

  5. Let start_kernel() build the LSP service

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0307a7a View commit details
    Browse the repository at this point in the history

  6. Another bit of rationale

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f57aa38 View commit details
    Browse the repository at this point in the history

  7. Switch to trace!() and use log:: everywhere

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f467711 View commit details
    Browse the repository at this point in the history

  8. Separate constructor and runner

    @DavisVaughan
    DavisVaughan committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cf346b5 View commit details
    Browse the repository at this point in the history