Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft integration tests for Ark #542

Merged
merged 36 commits into from
Sep 27, 2024
Merged

Draft integration tests for Ark #542

merged 36 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Rename Frontend to DummyFrontend

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6ef1332 View commit details
    Browse the repository at this point in the history

  2. Export DummyFrontend from Amalthea

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6ecf5a9 View commit details
    Browse the repository at this point in the history

  3. Rename shell_tx to iopub_tx

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    843f7cc View commit details
    Browse the repository at this point in the history

  4. Export start_kernel() for tests

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7392c20 View commit details
    Browse the repository at this point in the history

  5. Add scaffholding for protocol tests

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8457652 View commit details
    Browse the repository at this point in the history

  6. Fix R arguments

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    001850f View commit details
    Browse the repository at this point in the history

  7. Implement suicide hook

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7210e8a View commit details
    Browse the repository at this point in the history

  8. Wrap dummy Ark frontend in singleton 

    Checks for crumbs on drop
    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8500112 View commit details
    Browse the repository at this point in the history

  9. Export DummyArkFrontend from Ark

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4441514 View commit details
    Browse the repository at this point in the history

  10. Add send_execute_request() method

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    45478e4 View commit details
    Browse the repository at this point in the history

  11. Add more wrapper methods

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    788b0ca View commit details
    Browse the repository at this point in the history

  12. Rename receive_ prefix to recv_

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7f024e9 View commit details
    Browse the repository at this point in the history

  13. Rename test/test.rs to test/utils.rs

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e5c2ea4 View commit details
    Browse the repository at this point in the history

  14. Don't set R_HOME in kernel spec 

    Let Ark detect it from the search path via `R RHOME`
    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0288a3b View commit details
    Browse the repository at this point in the history

  15. Set RUST_LOG in kernel spec

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3f469a8 View commit details
    Browse the repository at this point in the history

  16. Move start_r() to RMain::start()

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6c6866f View commit details
    Browse the repository at this point in the history

  17. Add RMain::wait_r_initialized() 

    And rename `RMain::initialized()` to `RMain::is_initialized()`
and make it thread-safe. It seems safer for static methods of `RMain` should be
made thread-safe.
    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    13fc7e6 View commit details
    Browse the repository at this point in the history

  18. Set unlimited stack size in unit tests

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c7a4adc View commit details
    Browse the repository at this point in the history

  19. Enable test-only features for integration tests

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    242359d View commit details
    Browse the repository at this point in the history

  20. Set stack size after initializing R

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    51fdd2d View commit details
    Browse the repository at this point in the history

  21. Set Suicide on Windows

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    beb5ff1 View commit details
    Browse the repository at this point in the history

  22. Use IS_TESTING in modules::initialize()

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ba22890 View commit details
    Browse the repository at this point in the history

  23. Add RMain::wait_initialized()

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b1847e9 View commit details
    Browse the repository at this point in the history

  24. Provide debug information about incoming data

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ff4ef91 View commit details
    Browse the repository at this point in the history

  25. Comment on use of once_cell::Lazy

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1353cf8 View commit details
    Browse the repository at this point in the history

  26. Use OnceLock instead of once_cell::Lazy

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4945eba View commit details
    Browse the repository at this point in the history

  27. Move test fixtures to src/fixtures

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3229efb View commit details
    Browse the repository at this point in the history

  28. Reuse socket receivers

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a50b20e View commit details
    Browse the repository at this point in the history

  29. Fix typo in .complete_initialization()

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    dd5240a View commit details
    Browse the repository at this point in the history

  30. Include review suggestions

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0e927ee View commit details
    Browse the repository at this point in the history

  31. Remove wait_initialized()

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a62db57 View commit details
    Browse the repository at this point in the history

  32. Use IS_TESTING instead of RMain::is_initialized()

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    755a0e9 View commit details
    Browse the repository at this point in the history

  33. Use RMain::is_initialized() after all

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    47af0ad View commit details
    Browse the repository at this point in the history

  34. Panic if RMain::start() is called more than once

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    fafbd8c View commit details
    Browse the repository at this point in the history

  35. Remove RMain::initializing flag 

    And use `RMain::is_r_initialized()` instead
    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1f5753d View commit details
    Browse the repository at this point in the history

  36. Document reliance on resolver's version 2

    @lionel-
    lionel- committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5af6ba6 View commit details
    Browse the repository at this point in the history