-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define include, share, and doc environment variables #640
Conversation
crates/harp/src/command.rs
Outdated
@@ -24,9 +24,18 @@ where | |||
{ | |||
assert!(COMMAND_R_LOCATIONS.len() > 0); | |||
|
|||
// If `R_HOME` is defined use that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that r_command()
works properly when the currently active R is not the same as the one on the path.
396282f
to
9cdea69
Compare
F: Fn(&mut Command), | ||
{ | ||
assert!(COMMAND_R_LOCATIONS.len() > 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split into r_command()
and r_command_from_path()
or r_home_from_path()
depending on what makes sense
93e2158
to
8b21487
Compare
8b21487
to
c804fdb
Compare
Addresses posit-dev/positron#3637.
Positron Notes
Release Notes
New Features
Bug Fixes
The following environment variables are now set in the same way that R does:
R_SHARE_DIR
R_INCLUDE_DIR
R_DOC_DIR
This solves a number of problems in situations that depend on these variables being defined (Ark: Set
R_INCLUDE_DIR
andR_SHARE_DIR
envvars? positron#3637).QA Notes
This should not fail:
We test for these on our side.