Fix ark --install on Linux
#712
Open
+38
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix `--connection_file` error
DavisVaughan
approved these changes
Feb 21, 2025
Comment on lines
129
to
132
| "--install" => { | ||
| install_kernel_spec()?; | ||
| has_action = true; | ||
| return Ok(()); | ||
| }, |
There was a problem hiding this comment.
Oh wow it was trying to start ark when you --install?
Comment on lines
+59
to
+61
| let r_home: String = r_home_setup().to_string_lossy().to_string(); | ||
|
|
||
| let output = r_command(|command| { | ||
| let output = r_command_from_path(|command| { |
There was a problem hiding this comment.
I think it is best to call r_command() here because you called r_home_setup() right above this, which sets you up to be able to call r_command() with the same R_HOME that r_home_setup() found.
Comment on lines
+33
to
+56
| pub(crate) fn r_home_setup() -> PathBuf { | ||
| match std::env::var("R_HOME") { | ||
| Ok(home) => { | ||
| // Get `R_HOME` from env var, typically set by Positron / CI / kernel specification | ||
| PathBuf::from(home) | ||
| }, | ||
| Err(_) => { | ||
| // Get `R_HOME` from `PATH`, via `R` | ||
| let Ok(result) = r_command_from_path(|command| { | ||
| command.arg("RHOME"); | ||
| }) else { | ||
| panic!("Can't find R or `R_HOME`"); | ||
| }; | ||
|
|
||
| let r_home = String::from_utf8(result.stdout).unwrap(); | ||
| let r_home = r_home.trim(); | ||
|
|
||
| // Now set `R_HOME`. From now on, `r_command()` can be used to | ||
| // run exactly the same R as is running in Ark. | ||
| unsafe { std::env::set_var("R_HOME", r_home) }; | ||
| PathBuf::from(r_home) | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
Would you mind moving this to command.rs in harp instead? It is extremely related to r_command(), as you can see from this comment just above
// Now set `R_HOME`. From now on, `r_command()` can be used to
// run exactly the same R as is running in Ark.
So i think it makes sense to move it there and add a doc comment like
/// Use this before calling `r_command()` to ensure that `R_HOME` is set consistently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix
--connection_fileerror.Closes #648.