Connect User Metrics

[jakubnowicki]

Dashboard for presenting the adoption data for the content deployed on Posit Connect, created by Appsilon.

Standalone repository: https://github.com/Appsilon/ConnectUserMetrics

[dotNomad]

Howdy @jakubnowicki 👋

Thanks for submitting this PR to contribute to the Connect Gallery! I'm still working through this PR to give it a full review, but I figured I'd post my in progress comments and questions so we could start some back and forth while I work through it.

[dotNomad]

Great README. I noticed you included a short description in the manifest.json, but it could be helpful to add a description here as well. Perhaps one even longer that gives an indication of what functionality to expect.

Additionally I see the "Connect Insights Dashboard" naming here, but the directory and manifest.json use "Connect User Metrics" I was curious about the difference in naming.

[vituri]

Excellent idea! I will copy the content of the in-app "help button" here, so we have a better description of what the app really does.

About the naming convention: you are right, we will stick to "Connect User Metrics".

[dotNomad]

Looks like there is a typo here.

Suggested change

	[User Guide Vars]: https://docs.posit.com/connect/user/content-settings/#content-vars
	[User Guide Vars]: https://docs.posit.co/connect/user/content-settings/#content-vars

[vituri]

Nice catch!

[dotNomad]

I noticed there are some features not included in the README that are in the Appsilon/ConnectUsersMetrics repo README. That totally makes sense given how the READMEs will be consumed for Gallery content.

It makes me wonder if there should be a CONTRIBUTING guide here that includes some of those details so this file, for example, is a bit easier to understand.

[vituri]

This app here is a simplified version of the origina Connect User Metrics; some of the features only make sense in the complete app, where the user is able to modify some configuration files.

I will add a CONTRIBUTE file pointing to the original branch.

[dotNomad]

It looks like the js file is empty other than this one file. Is there a reason to keep it around that I'm missing?

[vituri]

You are right! These files (together with Cypress testing) are automatically generated Rhino, the framework we used to make this app. I will delete it for the sake of simplicity.

[dotNomad]

It looks like the Cypress tests aren't used here and there isn't a package.json to setup Cypress with npm. Can we remove the Cypress config and this empty test file?

When Cypress tests are added in the future we can get them added back :)

[vituri]

(Same answer as above; I will delete the file).

[dotNomad]

It looks like this is being generated from main.scss. but I'm curious how this is being generated. I don't see anything mentioned in the README here or over in https://github.com/Appsilon/ConnectUserMetrics

Forgive me this may be some of my own unfamiliarity with styling Shiny apps.

[vituri]

The minified CSS is generated by running rhino::build_sass(); it is a common practice when using Rhino, but we probably can make that more clear in the main repository of Connect User Metrics.

[vituri]

Hey, @dotNomad , thank for the quick review! Jakub is on vacation right now, so I will try to answer some of your comments. I made a PR-to-this-branch fixing the issues you pointed. As soon as Marcin approves it, we can make a new round of reviews.