Skip to content

Language Runtime terminals not hidden from end users #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmcphers opened this issue Feb 27, 2023 · 1 comment · Fixed by #272
Closed

Language Runtime terminals not hidden from end users #214

jmcphers opened this issue Feb 27, 2023 · 1 comment · Fixed by #272
Milestone

Comments

@jmcphers
Copy link
Collaborator

Currently, it is possible to see the Language Runtime terminals as active terminals in the Terminal tab of Positron. They should not be visible, since the fact that we are using Terminals to host Language Runtime instances is an implementation detail.

This behavior is controlled by the hideFromUser flag of the Terminal API; unfortunately, terminals that are hidden from users appear to be forced into transient mode, which prevents them from being persisted on reload.

So we need some way for a terminal to be all of the above:

It'd also be nice to have an option to make the terminals visible for development, debugging, or troubleshooting purposes, even though we will hide them from end users in the default configuration.

@jmcphers jmcphers added this to the Internal Preview milestone Feb 27, 2023
@petetronic
Copy link
Collaborator

It turns out that configuring hideFromUser as true causes a terminal to be backgrounded, i.e. means window.terminals doesn't know about them and they are instead stored in a special _backgroundedTerminalInstances member of terminalService. So they are there on reload, but we would need access to currently private members to find them.
https://github.com/rstudio/positron/blob/main/src/vs/workbench/contrib/terminal/browser/terminalService.ts#L62

wesm pushed a commit that referenced this issue Mar 28, 2024
…ristic

Merge pull request #214 from posit-dev/immediate-startup

refine immediate startup heuristic
--------------------
Commit message for posit-dev/positron-python@2a5a988:

refine immediate startup heuristic

Restrict config files to the workspace root. See this discussion for
more: #1289 (comment).

Also fixes the `.venv` and `.conda` cases which were incorrectly
searching for files with those names instead of folders.

Relates to #1282.


Authored-by: Wasim Lorgat <mwlorgat@gmail.com>
Signed-off-by: Wasim Lorgat <mwlorgat@gmail.com>
wesm pushed a commit that referenced this issue Mar 28, 2024
…ristic

Merge pull request #214 from posit-dev/immediate-startup

refine immediate startup heuristic
--------------------
Commit message for posit-dev/positron-python@2a5a988:

refine immediate startup heuristic

Restrict config files to the workspace root. See this discussion for
more: #1289 (comment).

Also fixes the `.venv` and `.conda` cases which were incorrectly
searching for files with those names instead of folders.

Relates to #1282.


Authored-by: Wasim Lorgat <mwlorgat@gmail.com>
Signed-off-by: Wasim Lorgat <mwlorgat@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants