Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to set the publisher field for extensions #5268

Open
jennybc opened this issue Nov 4, 2024 · 0 comments
Open

Decide how to set the publisher field for extensions #5268

jennybc opened this issue Nov 4, 2024 · 0 comments

Comments

@jennybc
Copy link
Member

jennybc commented Nov 4, 2024

I'm talking about this, e.g.:

"publisher": "vscode",

A possibly incomplete list of technical implications:

  • An extension can register a URI handler, which is something I'm implementing for positron-r, starting with (Start to) handle cli hyperlinks in the terminal used for pkg dev tasks #5231. An extension can only address URIs addressed to it, which means they must start like so:

    {product-name}://{publisher}.{extension.name}
    

    In (Start to) handle cli hyperlinks in the terminal used for pkg dev tasks #5231, I've made positron the publisher of positron-r. That's not written in stone, but I'm quite sure it should not be vscode. For "normal" (meaning: not built-in) extensions, this really is a publisher in the marketplace sense and, when such a URI is activated, it leads to activation and/or installation of said extension.

  • If we offer a way for folks to launch Positron without any non-built-in extensions, similar to --disable-extensions, you could imagine the publisher field possibly being relevant.

  • Unknown unknowns: what happens if we switch all of "our" (for some definition of "our", see below) extension to have positron or posit as the publisher? Literally, what happens with our tests?

More questions:

  • What should the publisher be? positron? posit?
    • The Shiny-related extensions are published by Posit in both the VS Code Marketplace and in the OpenVSX Registry, so I suspect it would be confusing to use posit for extensions, like positron-r, that are built-in.
  • Which extensions should we change publisher for? The positron-* extensions seem like a clear yes, although positron-python is a special duck. Anything else?

Docs on publishing, which include a wee bit on the significance of the publisher field (though not much relevant to our case):

https://code.visualstudio.com/api/working-with-extensions/publishing-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant