Add more R language config #1479
Conversation
|
Turns out you can contribute more stuff (like |
| @@ -179,6 +179,9 @@ | |||
| "R", | |||
| "r" | |||
| ], | |||
| "filenames": [ | |||
| "NAMESPACE" | |||
There was a problem hiding this comment.
There are two directions we can go with NAMESPACE, either treat it like R syntax or treat it like a separate language. I vote for treating it like R syntax, like Hadley says here.
There was a problem hiding this comment.
I'm fine with this. The vscode-R extension did implement their own, so in case we ever decide to revisit this, here's their PR with a little bit of discussion:
I'd say the justification for creating a NAMESPACE language configuation is pretty weak and it's reasonable to piggyback off of R.
| @@ -179,6 +179,9 @@ | |||
| "R", | |||
| "r" | |||
| ], | |||
| "filenames": [ | |||
| "NAMESPACE" | |||
There was a problem hiding this comment.
I'm fine with this. The vscode-R extension did implement their own, so in case we ever decide to revisit this, here's their PR with a little bit of discussion:
I'd say the justification for creating a NAMESPACE language configuation is pretty weak and it's reasonable to piggyback off of R.
| @@ -0,0 +1,114 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this file coming from vscode-R? This is just a curiosity / provenance question.
There was a problem hiding this comment.
I started with what vscode-R does but made a few changes, based on my opinions 😆 and what RStudio does. (The vscode-R extension is very into UNDERLINING.)
There was a problem hiding this comment.
Ooh, this is a very interesting folder to know about!
https://github.com/rstudio/rstudio/tree/main/src/gwt/acesupport/acemode
Addresses #125
This PR will include the language highlighting config for
NAMESPACEand.Rdfiles. Anrenv.lockis a JSON file so we should be able to inherit that highlighting somehow.