Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum renv version to 1.0.9 #4854

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

juliasilge
Copy link
Contributor

Addresses #3439

QA Notes

If you have renv < 1.0.8 installed and trigger the "r.renvInit" command (via the New Project Wizard or directly) you will see:

Screenshot 2024-09-30 at 3 28 20 PM

@juliasilge juliasilge marked this pull request as ready for review September 30, 2024 21:30
@juliasilge juliasilge requested a review from timtmok September 30, 2024 22:03
@jennybc
Copy link
Member

jennybc commented Sep 30, 2024

FYI it looks like renv has advanced to 1.0.9 already:

rstudio/renv#1990

@juliasilge
Copy link
Contributor Author

Ah, and looks like 1.0.8 had a fairly noticeable regression. I will bump yet again!

@juliasilge juliasilge changed the title Bump minimum renv version to 1.0.8 Bump minimum renv version to 1.0.9 Sep 30, 2024
@jennybc
Copy link
Member

jennybc commented Sep 30, 2024

I haven't rerun the motivating use case for my PR to renv (the "cold start" from a colleague) with renv 1.0.9, but hopefully a Positron user still sees the advice re: renv::restore(): rstudio/renv#1915 (comment)

Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliasilge juliasilge merged commit 6b53586 into main Oct 1, 2024
3 checks passed
@juliasilge juliasilge deleted the bump-minimum-renv-version branch October 1, 2024 17:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants