Fix version build number in DEB and RPM package info #5140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
0
in DEB and RPM package version info #5159Changes
positronBuildNumber
from the package.json file will always be zero -- instead, we need to use the calculated build number from show-version.js when possible.0
in the DEB and RPM package info.positronBuildVersion
variable is now in a separate util file, so the value can be used across the gulpfiles.QA Notes
I've checked the version output of the DEB on Ubuntu 24 (x86_64) and the RPM on Fedora 40 (arm).
DEB
dpkg --info <POSITRON_BINARY>.deb
<POSITRON_VERSION>+<BUILD_NUMBER>-<LINUX_REVISION>
Sample Output:
RPM
rpm -qi <POSITRON_BINARY>.rpm
<POSITRON_VERSION>+<BUILD_NUMBER>
Sample Output: