Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version build number in DEB and RPM package info #5140

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

sharon-wang
Copy link
Member

@sharon-wang sharon-wang commented Oct 23, 2024

Summary

Changes

  • The positronBuildNumber from the package.json file will always be zero -- instead, we need to use the calculated build number from show-version.js when possible.
  • We are already using the calculated build number in a few places, but a few were missing, resulting in a build number of zero 0 in the DEB and RPM package info.
  • The positronBuildVersion variable is now in a separate util file, so the value can be used across the gulpfiles.

QA Notes

I've checked the version output of the DEB on Ubuntu 24 (x86_64) and the RPM on Fedora 40 (arm).

DEB

  1. Run dpkg --info <POSITRON_BINARY>.deb
  2. Confirm the Version field in the output shows <POSITRON_VERSION>+<BUILD_NUMBER>-<LINUX_REVISION>

Sample Output:

<SOME_INITIAL_INFO>
Package: positron
Version: 2024.11.0+999-1729709839
<REST_OF_INFO>

RPM

  1. Run rpm -qi <POSITRON_BINARY>.rpm
  2. Confirm the Version field in the output shows <POSITRON_VERSION>+<BUILD_NUMBER>

Sample Output:

Name        : positron
Version     : 2024.11.0+999
<REST_OF_INFO>

The `positronBuildNumber` from the package.json file will always be zero -- instead, we need to use the calculated build number from show-version.js when possible.

We are already using the calculated build number in a few places, but a few were missing.

The `positronBuildVersion` variable is now in a separate util file, so the value can be used across the gulpfiles.
@sharon-wang sharon-wang merged commit fa567b2 into main Oct 25, 2024
3 checks passed
@sharon-wang sharon-wang deleted the fix-deb-rpm-positron-build-number branch October 25, 2024 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants