-
Notifications
You must be signed in to change notification settings - Fork 99
Start supervisor concurrently with Positron server; address some state issues #7198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jmcphers
wants to merge
21
commits into
main
Choose a base branch
from
bugfix/session-persistence-scoping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+369
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Tests 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses some of the edge cases around the relationship between Positron Workbench sessions, browser tab sessions, extension host sessions, supervisor sessions, and R/Python sessions.
The primary change is the way the supervisor is started in Workbench. Formerly, it worked the same way it did on Desktop: every workspace started its own supervisor. Now:
This improves performance, because the supervisor is already warm by the time we're ready to start a session. It also fixes some state issues that arise from storing the supervisor connection information in workspace state, which is too durable; on Workbench, the connection information now comes from a session-scoped file path.
The remainder of the change is around handling multiple tabs connecting to the same workspace. When this happens, you will now see a dialog explaining what happened, along with a message in the Console showing that your sessions have been transferred to the new window.
Positron should otherwise keep running fine in the old window if you have any non-data-related work to do, such as finishing up with script edits or Terminal tasks.
You might be wondering what happens if you start a new session in a tab after its existing sessions get moved to another tab. The system is designed to handle this; you can perform this move to get two tabs with different sets of sessions going against one workspace if you really want/need to. Opening a new tab (or reloading an existing one) will cause it to adopt all the sessions from any other tabs/windows, by design, so that you can't orphan any sessions.
Addresses #5374
Addresses #6174
Addresses #6799
Addresses #7157
Partially addresses #7078 (workbench only)
Release Notes
New Features
Bug Fixes
QA Notes
This is a high-risk change because it affects how we start and reconnect to sessions, which involves a lot of different pieces (see list of "sessions" above) plus a lot of different state stored in a lot of different places.
Things that deserve extra attention:
Also note that in web mode, we can no longer respect the supervisor log level setting or the idle shutdown hours setting -- there is no (reasonable) way for us to read these settings at the time the supervisor is started. The latter setting doesn't make sense in web mode anyway; if we need to adjust the log level in web mode we will need to build another way to do it.
Test tags:
@:sessions