Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL support to HTMLDependency #53

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Add URL support to HTMLDependency #53

merged 4 commits into from
Mar 29, 2023

Conversation

schloerke
Copy link
Collaborator

Fixes #52

Can now add HTML Dependencies that have a source url:

    b1_10 = HTMLDependency(
        "b", "1.10", source={"href": "http://b.test.com"}, script={"src": "b2.js"}
    )

which renders in the <head> to:

<script src="http://b.test.com/b2.js"></script>

MUST set source to an object that contains key "href" with a URL location

@schloerke schloerke requested a review from wch March 27, 2023 18:23
@schloerke schloerke marked this pull request as ready for review March 27, 2023 18:23
@wch wch merged commit 70f0f0d into main Mar 29, 2023
@wch wch deleted the url_html_dep branch March 29, 2023 00:49
@schloerke schloerke mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should allow HTML dependencies from remote URLs
2 participants
@schloerke @wch