Skip to content

Conversation

@gadenbuie
Copy link
Contributor

Fixes #87

@gadenbuie gadenbuie force-pushed the gadenbuie/fix/issue-87 branch from 377808e to 52e2858 Compare May 10, 2024 13:45
@gadenbuie gadenbuie marked this pull request as ready for review May 10, 2024 13:59
@gadenbuie gadenbuie force-pushed the gadenbuie/fix/issue-87 branch from 42723b8 to 421fe31 Compare May 10, 2024 14:02
gadenbuie added 2 commits May 10, 2024 10:39
* Fix black changes
* flake8: ignore E704 which fights with black
* update type ignore comment for pyright
* raise an AssertionError instead of `assert False`
@gadenbuie gadenbuie requested a review from cpsievert May 10, 2024 14:45
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gadenbuie gadenbuie merged commit 75e1b8c into main May 10, 2024
@gadenbuie gadenbuie deleted the gadenbuie/fix/issue-87 branch May 10, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't copy a dependency that has all_files=True and includes a directory

3 participants