Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Deploy to Connect Cloud buttons to READMEs #25

Merged
merged 23 commits into from
Oct 2, 2024

Conversation

garrettgman
Copy link
Contributor

This PR adds a button to the README of each example app that allows users to quickly deploy the app to Connect Cloud and see it in action—with one click of the button. The PR does not otherwise affect the code in the apps or the repository.

The buttons look like this.

Screenshot 2024-09-26 at 1 11 34 PM

When I tested it, every app deployed within seconds.

Why add Deploy to Connect Cloud buttons?

Connect Cloud is part of Posit's strategy to provide value to Python users. With Connect Cloud, users can very quickly deploy and maintain Shiny apps straight from their Github repository. We believe in Connect Cloud as a company and want to highlight it alongside our own assets.

@icarusz
Copy link

icarusz commented Sep 28, 2024

This looks good to me, though should we put the button at the bottom of the descriptions... they are generally not too long and it seems like you might want to do it after reading the description rather than before?

@garrettgman
Copy link
Contributor Author

@icarusz, @schloerke proposed aligning the buttons to the top right of the README. This way the buttons:

  1. do not get in the way of reading the README
  2. do not look like banners
  3. do not risk falling below the fold, which can happen in some github views. At a glance, the reader knows they have the option to deploy the app.

I added the change to this, and the related, PRs.

@schloerke
Copy link

schloerke commented Oct 2, 2024

Thank you!

New look:
Screenshot 2024-10-02 at 2 18 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants