Fix logic for inferring window title from Tag/TagList objects #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
panel-title-fix
branch
from
e823277
to
7dc07bb
Compare
4 tasks
cpsievert
force-pushed
the
panel-title-fix
branch
2 times, most recently
from
669a966
to
01e8c92
Compare
cpsievert
force-pushed
the
panel-title-fix
branch
from
893aa99
to
015a692
Compare
cpsievert
force-pushed
the
panel-title-fix
branch
from
015a692
to
28e4bb6
Compare
jcheng5
reviewed
Apr 27, 2022
…ents don't produce extra spaces
jcheng5
reviewed
Apr 27, 2022
| return " ".join([_find_child_strings(y) for y in x]) | ||
| return x if isinstance(x, str) else "" | ||
| strings = [_find_child_strings(y) for y in x] | ||
| return " ".join(filter(lambda x: x != "", strings)) |
There was a problem hiding this comment.
Can you filter as part of the list comprehension? [_find_child_strings(y) for y in x if y != ""]
There was a problem hiding this comment.
I wish, but it would miss cases where y != "" and _find_child_strings(y) == ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #137
Also moves
get_window_titletoui._utilsin anticipation of #136 (this way navs.py will be able to import bootstrap.py without introducing a circular dependency)