Adds error message to deployment failure.

[tdstein]

Description

Connected to #247

On a failed deployment where the application already exists, additional context is added to the error message to provide the user with a recommended action.

Testing Notes / Validation Steps

A new unit test is added to validate that the original exception is caught, the new message is appended, and a new exception is thrown.

Manual Validation

1. Deploy a new application to connect.
2. Delete the application from connect.
3. Deploy the same application to connect.

After step 3, the following type of error message should be presented:

Error: Posit Connect reported an error (calling /__api__/applications/60e72620-6c3f-4666-8032-f049758cd19c): The requested object does not exist. Try setting the --new flag to overwrite the previous deployment.

[kgartland-rstudio]

Verified.

Previous Behavior:

> rsconnect deploy api ./ -s http://localhost:3939 -k ${DEFAULT_ADMIN_API_KEY}
Validating server... 	[OK]
Validating app mode... 	[OK]
Making bundle ... 	[OK]
Deploying bundle ... 	[ERROR]: Posit Connect reported an error (calling /__api__/applications/4ca1c497-3cdf-40c5-ae0f-f427281d7007): The requested object does not exist.
Error: Posit Connect reported an error (calling /__api__/applications/4ca1c497-3cdf-40c5-ae0f-f427281d7007): The requested object does not exist.

New Error:

> rsconnect deploy api ./ -s http://localhost:3939 -k ${DEFAULT_ADMIN_API_KEY}
Validating server... 	[OK]
Validating app mode... 	[OK]
Making bundle ... 	[OK]
Deploying bundle ... 	[ERROR]: Posit Connect reported an error (calling /__api__/applications/4ca1c497-3cdf-40c5-ae0f-f427281d7007): The requested object does not exist. Try setting the --new flag to overwrite the previous deployment.
Error: Posit Connect reported an error (calling /__api__/applications/4ca1c497-3cdf-40c5-ae0f-f427281d7007): The requested object does not exist. Try setting the --new flag to overwrite the previous deployment.

However when you specify an --app-id we send the old error. Can we update this path too while we're at it?

> rsconnect deploy api ./ -s http://localhost:3939 -k ${DEFAULT_ADMIN_API_KEY} --app-id 12
Validating server... 	[OK]
Validating app mode... 	[ERROR]: Posit Connect reported an error (calling /__api__/applications/12): The requested object does not exist.
Error: Posit Connect reported an error (calling /__api__/applications/12): The requested object does not exist.
``

[tdstein]

Resolves #247

[tdstein]

However when you specify an --app-id we send the old error. Can we update this path too while we're at it?

Thanks, @kgartland-rstudio - I will add this change.

[bcwu]

Marking this entire block for one error feels a bit odd, as other unrelated errors might occur. Another way to do this could be to use get_app_info to check whether the app still exists. The place for adding the specific exception would be L847-L857.

[tdstein]

Thanks, @bcwu - I've updated the try/except block to be more specific.

[tdstein]

@kgartland-rstudio - would you like to revalidate this?

[kgartland-rstudio]

@kgartland-rstudio - would you like to revalidate this?

Sure, sorry I didn't see that was ready to go.

[tdstein]

@kgartland-rstudio - would you like to revalidate this?

Sure, sorry I didn't see that was ready to go.

No worries! This is pretty low priority.

[kgartland-rstudio]

This looks good in both cases now:

> rsconnect deploy notebook content/notebook/stock-report-jupyter.ipynb --app-id 234 -s http://localhost:3939 -k ${DEFAULT_ADMIN_API_KEY}
Validating server... 	[OK]
Validating app mode... 	[ERROR]: Posit Connect reported an error (calling /__api__/applications/234): The requested object does not exist. Try setting the --new flag to overwrite the previous deployment.
Error: Posit Connect reported an error (calling /__api__/applications/234): The requested object does not exist. Try setting the --new flag to overwrite the previous deployment.