spcs support #651
Draft
spcs support #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -234,9 +234,33 @@ def __init__( | |||
| self.ca_data = ca_data | |||
| # This is specifically not None. | |||
| self.cookie_jar = CookieJar() | |||
| # 🤡 | |||
| self.snowflake_connection_name = None | |||
There was a problem hiding this comment.
Curious as to why this is needed here but not in the other non SPCS targetable servers.
aronatkins
reviewed
Mar 26, 2025
aronatkins
reviewed
Mar 26, 2025
aronatkins
reviewed
Mar 26, 2025
pass a --snowflake-connection-name argument to the CLI, which uses the snow cli to obtain connection details and perform token exchange on each call to connect supports rsconnect add, details, and deploy_html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial support for interacting with Connect in SPCS
Intent
Type of Change
Approach
Take an optional dependency on the snow CLI
commands requiring interaction with remote servers gain an optional --snowflake-connection-name argument
The ingress URL, account name, and keypair configured out of band are sufficient information
to obtain the OAuth token required to interact with Connect in SPCS.
supports rsconnect add, details, and deploy_html
Automated Tests
Directions for Reviewers
Checklist