-
Notifications
You must be signed in to change notification settings - Fork 25
spcs support #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
spcs support #660
Conversation
add support for deployments and administrative actions for Connect in SPCS
Where is the best place to document this optional dependency and how it works? |
And for pip,
|
I didn't see this on your previous branch but maybe a debug flag is turned on? Seeing all these logs when deploying. If that is expected now, then please ignore:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but otherwise looks good!
In terms of testing, is it required to test deploying all types of content or are there existing tests that would cover those capabilities since that is downstream from authentication with the server? |
add support for deployments and administrative actions for Connect in SPCS
Type of Change
Approach
Automated Tests
Added new tests covering new API class and snowflake-cli
Directions for Reviewers
One shot:
Realistic:
Checklist