Skip to content

Commit

Permalink
revert gotosymbolsusinguqicpikc commands and turn strict off for test
Browse files Browse the repository at this point in the history
  • Loading branch information
pospisilf committed Feb 28, 2024
1 parent 67c54d6 commit 58870f3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
19 changes: 4 additions & 15 deletions src/ui-test/tests/code.navigation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,21 +182,10 @@ describe('Code navigation', function () {
*/
async function gotoSymbolsUsingQuickpickCommand(listOfAvailableSymbols: (string | number)[][], title: string): Promise<void> {
for (const quickpick of quickPicks) {
if (listOfAvailableSymbols && quickpick) {
const index = quickpick.getIndex();
if (index !== undefined && index >= 0 && index < listOfAvailableSymbols.length) {
const symbol = listOfAvailableSymbols[index];
if (symbol && symbol.length >= 2) {
const symbolName = symbol[0] as string;
const expectedCoords = symbol[1] as number;

await selectSymbolFromProposals(symbolName);
const editor = await activateEditor(driver, title);
const coords = (await editor.getCoordinates())?.[0]; // get active line in editor
assert.equal(coords, expectedCoords);
}
}
}
await selectSymbolFromProposals(listOfAvailableSymbols.at(quickpick.getIndex()).at(0) as string);
const editor = await activateEditor(driver, title);
const coords = (await editor.getCoordinates()).at(0); // get active line in editor
assert.equal(coords, listOfAvailableSymbols.at(quickpick.getIndex()).at(1));
}
}

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"outDir": "out",
"resolveJsonModule": true,
"strict": true, // true causes like million errors here
"strict": false, // true causes like million errors here
"forceConsistentCasingInFileNames": true
},
"include": [
Expand Down

0 comments on commit 58870f3

Please sign in to comment.