fix: also log clean messages for CRAM-MD5 failures (#1182 pt2) #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2022
Closed
|
as long as it still allows you to send messages using SMTP and CRAM-MD5 then 👌 |
Not entirely clear if that´s a question or a statement, so in case: |
|
@adamcooke could you have a look here please? (sorry for the bump, but given "this is security", possible to get a rather timely release - especially now that were all forced to docker? 😢 (I have send a PR to fix that ci-build as well ;-) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please see #1182 (comment)
auth/login gets logged, but seems cram failures were missed.
this code has been tested with wrong user, wrong password, and the correct variants of either and works as expected
-> but i don´t actually ruby, so feel free to rework this to wrap the message in a function or there like =)