-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop dependency on gulp-util #137
Conversation
because it's deprecated https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
@ohbarye hi! Looks good to me. What should I do with the version bump? Are these changes backwards compatible and work with the old gulp? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine overall but vinyl
should be in the devDependencies
.
I also see that you used fancyLog.info
instead of fancyLog
. This does a console.info
instead of console.log
. I am not sure if this change has a real impact but I see why you did it: it's because the tests rely on the global cache of the modules to stub logging. It's not very clean but fixing it is a lot more involved: I am not even sure what is the best solution. Before I saw your PR, I wrote my own where I used fancyLog
and exposed it as an internal property of postcss
for testing. You can see it there.
@@ -50,6 +51,7 @@ | |||
"mocha": "^3.4.2", | |||
"nyc": "^11.0.3", | |||
"proxyquire": "^1.8.0", | |||
"sinon": "^2.3.5" | |||
"sinon": "^2.3.5", | |||
"vinyl": "^2.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vinyl
should be in the devDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review, but vinyl
is already in the devDependencies
. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I got confused.
@w0rm |
@demurgos thanks for taking a look! |
@ohbarye thanks for your contribution, I've just released v7.0.1 |
@w0rm Thanks for your review and merge! |
Hello maintainers.
Following gulpjs/gulp-util#143, I dropped dependency on gulp-util.
closes #136
Thanks!