-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for postcss 8 plugins #200
feat: support for postcss 8 plugins #200
Conversation
@michael-ciniawsky can you give me access to the repo and npm package? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do Not Merge; this breaks linting, and I am 99% sure this does not function correctly.
Can you expand on that? Happy to adjust |
Refs postcss/postcss#1410
Specifically, I'm not sure what this logic is doing, but I'm pretty sure it's not doing its intended purpose: https://github.com/michael-ciniawsky/postcss-load-config/blob/b03d1950e243f16cd3feb6d9948d35de37cefe37/src/plugins.js#L59-L61 Also, not sure what this |
Alright, sounds like I'll need to wait for you to come back to me with your conclusion. Please keep me posted, or feel free to scrap that PR with a proper fix if that's easier for you 👍 |
We need a different way to fix #202 |
Notable Changes
This PR is aiming to support postcss 8 plugins. Not sure if I cover everything in there, or if I should be adding any additional tests
Commit Message Summary (CHANGELOG)
Support for postcss 8 plugins
Type
SemVer
Issues
Checklist