Support loading ECMAScript modules, but drop sync API (#230) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Mar 29, 2022
src/index.js
Outdated
| } | ||
| } | ||
|
|
||
| // prefers import, which won't work in sync mode |
There was a problem hiding this comment.
Will it better to check Node.js version?
There was a problem hiding this comment.
I think feature detection is a bit cleaner, as it might support different runtimes (like Deno). Although in this case, the feature-detection is quite Node-specific and I don't find documentation for it in the Node 10 docs.
michael42
force-pushed
the
esm
branch
2 times, most recently
from
3475c1c
to
0a96011
Compare
michael42
force-pushed
the
esm
branch
2 times, most recently
from
c8a7e26
to
fac2e53
Compare
michael42
changed the title
|
I will put this task on a little hold until Node.js 12 EOL |
@ai That time has come. See the release chart. |
|
Released in 4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable ChangesThis PR implements support for
.mjsconfig files (and.jsconfig files within"type": "modules"projects). To support that without much hassle, support for synchronously loading configs is dropped, as ECMAScript Modules are loaded inherently async.Commit Message Summary (CHANGELOG)TypeSemVerIssues#230Checklist