Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Convert paths to fix ERR_UNSUPPORTED_ESM_URL_SCHEME errors on Windows #238

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: Convert paths to fix ERR_UNSUPPORTED_ESM_URL_SCHEME errors on Windows #238

merged 1 commit into from
May 31, 2022

Conversation

michael42
Copy link
Contributor

@michael42 michael42 commented May 30, 2022 •
edited
Loading

Notable Changes

Uses url.pathToFileURL when loading using await import(), because that only supports URLs. It worked coincidentally on Linux and MacOS, because they use the same path separator as URLs (/).

Commit Message Summary (CHANGELOG)

fix: Convert paths to fix ERR_UNSUPPORTED_ESM_URL_SCHEME errors on Windows

Type

  • CI
  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Style
  • Build
  • Feature
  • Refactor

SemVer

  • Fix (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Issues

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works

@ai ai merged commit 4acf85e into postcss:main May 31, 2022
@ai
Copy link
Member

ai commented May 31, 2022

Thanks. Released in 4.0.1.

@michael42 michael42 deleted the fix-windows-url-issue branch July 29, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-ciniawsky michael-ciniawsky Awaiting requested review from michael-ciniawsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v.4.0.0 ESM err on Windows 11
2 participants
@michael42 @ai