chore: fix error assertions #264
Conversation
test/Errors.test.js
Outdated
| // FIXME: this is resolving to nearest postcss config (outside root) | ||
| // test('Loading Config - {Error}', async () => { | ||
| // await rejects(() => postcssrc({}, 'test/err'), { | ||
| // message: /^No PostCSS Config found in: (.*)$/ | ||
| // }) | ||
| // }) |
There was a problem hiding this comment.
not fully sure what's the expected behavior here, but this is not throwing any error and resolving to test/postcss.config.mjs
There was a problem hiding this comment.
Seems like this test never moved to match area (this is why rejects is better).
As I understand it should ignore error in broken config and return No PostCSS Config found in. What is current behaviour in this test?
There was a problem hiding this comment.
Ah, currently there is no postcssrc file directly inside test/err. Running postcssrc({}, 'test/err') is not failing and returning content from test/postcss.config.mjs (one directory up the passed directory). Should it fail if there is no config directly inside the specified path?
There was a problem hiding this comment.
Let’s remove test. It is rare case and test didn’t work for a while.
|
Thanks! |
Notable Changes.catch+match/equalsdoesn't assert that a particular call throws error. It just asserts IF an error is thrown it will satisfy assertions inside. Consequently, it will pass the test even if something doesn't throw while it should.TypeSemVerChecklist