-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizeSvgEncode unclosed string #105
Comments
Looks like this retains the input css's quoting, so this works ok: .style {
background-image: url("./image.svg");
} But this fails: .style {
background-image: url(./image.svg);
} Quotes on file path urls are optional according to the css spec, but maybe this module should enforce adding quotes when inlining. |
@gdub22 thanks for feedback. Yes, you're right. I will try fix it soon. |
replace https://github.com/postcss/postcss-url/blob/master/src/type/inline.js#L81 on
work for me. |
fixed here #7.1.1 |
Last version of `postcss-url` was have a bug with path without quotes. Now it was fixed: postcss/postcss-url#105 (comment)
Thank you. Confirmed it's working. |
Thanks for the optimizeSvgEncode feature.
It appears to be creating invalid css:
Module build failed: Unclosed string
Look like it's because Inlining inserts without wrapping the whole thing in quotes and there are now unencoded quotes in the svg when using optimizeSvgEncode
The text was updated successfully, but these errors were encountered: