Add rocksdb interface #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Milchstra3e
commented
Jul 31, 2022
Milchstra3e
commented
- add some dependency
- add rocksdb_kv module
- implement rocksdb functions except revert_to_latest_checkpoint
junha1
reviewed
Aug 27, 2022
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| let result = self.db.put(key.as_ref(), value); | ||
| match result { | ||
| Ok(_) => Ok(()), | ||
| Err(_) => Err(super::Error::Unknown("unknown error".to_string())), |
There was a problem hiding this comment.
use the err information, not just discarding it
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| let result = self.db.delete(key.as_ref()); | ||
| match result { | ||
| Ok(_) => Ok(()), | ||
| Err(_) => Err(super::Error::NotFound), |
There was a problem hiding this comment.
use the err information, not just discarding it
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| let result = self.db.get(key.as_ref()); | ||
| match result { | ||
| Ok(v) => Ok(v.unwrap()), | ||
| Err(_) => Err(super::Error::NotFound), |
There was a problem hiding this comment.
use the err information, not just discarding it
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| .unwrap(); | ||
| } | ||
|
|
||
| self.db = DB::open_default(new_current_db_dir.to_path_buf().as_path().join("db")).unwrap(); |
There was a problem hiding this comment.
Don't unwrap, but handle it and propagate using ?
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| .unwrap(); | ||
| checkpoint_db | ||
| .create_checkpoint(new_checkpoint_db_dir.to_path_buf().as_path().join("db")) | ||
| .unwrap(); |
There was a problem hiding this comment.
Don't unwrap, but handle it and propagate using ?
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| .unwrap(); | ||
| checkpoint_db | ||
| .create_checkpoint(checkpoint_db_dir.to_path_buf().as_path().join("db")) | ||
| .unwrap(); |
There was a problem hiding this comment.
Don't unwrap, but handle it and propagate using ?
kv-storage/src/rocksdb_kv/mod.rs
Outdated
|
|
||
| checkpoint_db | ||
| .create_checkpoint(current_db_dir.to_path_buf().as_path().join("db")) | ||
| .unwrap(); |
There was a problem hiding this comment.
Don't unwrap, but handle it and propagate using ?
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| .unwrap(); | ||
| checkpoint_db | ||
| .create_checkpoint(checkpoint_db_dir.to_path_buf().as_path().join("db")) | ||
| .unwrap(); |
There was a problem hiding this comment.
Don't unwrap, but handle it and propagate using ?
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| } | ||
|
|
||
| Ok(RocksDB { | ||
| db: DB::open_default(current_db_dir.to_path_buf().as_path().join("db")).unwrap(), |
There was a problem hiding this comment.
Don't unwrap, but handle it and propagate using ?
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| db.put(Hash256::hash("key3"), "val3").unwrap(); | ||
| db.put(Hash256::hash("key4"), "val4").unwrap(); | ||
|
|
||
| tmp_folder |
added 25 commits
August 27, 2022 18:06
add new folder(rocksdb) in kv-store init RocksDB struct without fields and implementation each functions
change folder name from rocksdb_kv to rocksdb change file name from rocksdb.rs to mod.rs
include rocksdb crate declare new field db in RocksDB struct implement function new / open / insert_or_update / remove / get
add new dependency mktemp use mktemp module implement comit_checkpoint
- add origin_path: PathBuf - add current_db_path: Temp - add checkpoint_Db_path: Temp - rewrite logic of new / open
junha1
reviewed
Aug 27, 2022
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| } | ||
|
|
||
| async fn contain(&self, key: Hash256) -> Result<bool, super::Error> { | ||
| let result = self.db.get(key.as_ref()).unwrap(); |
There was a problem hiding this comment.
please handle the error instead of unwrapping it
kv-storage/src/rocksdb_kv/mod.rs
Outdated
| let result = self.db.delete(key.as_ref()); | ||
| match result { | ||
| Ok(_) => Ok(()), | ||
| Err(e) => Err(super::Error::from(e)), |
junha1
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.