Feat: implement in-memory KVStorage #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junha1
reviewed
Sep 3, 2022
kv-storage/src/memory.rs
Outdated
| type DB = HashMap<Hash256, Vec<u8>>; | ||
|
|
||
| #[derive(Clone)] | ||
| pub struct IMDB { |
kv-storage/src/memory.rs
Outdated
|
|
||
| type DB = HashMap<Hash256, Vec<u8>>; |
kv-storage/src/memory.rs
Outdated
|
|
||
| #[derive(Clone)] | ||
| pub struct IMDB { | ||
| db: DB, |
kv-storage/src/memory.rs
Outdated
| impl KVStorage for IMDB { | ||
| async fn commit_checkpoint(&mut self) -> Result<(), Error> { | ||
| self.checkpoint = self.db.clone(); | ||
|
|
kv-storage/src/memory.rs
Outdated
| } | ||
|
|
||
| async fn get(&self, key: Hash256) -> Result<Vec<u8>, Error> { | ||
| match self.db.get(&key) { |
kv-storage/src/memory.rs
Outdated
| } | ||
|
|
||
| async fn contain(&self, key: Hash256) -> Result<bool, Error> { | ||
| match self.db.get(&key) { |
There was a problem hiding this comment.
For the similar reason with async fn remove, cannot implement that way.
kv-storage/src/memory.rs
Outdated
| } | ||
|
|
||
| async fn remove(&mut self, key: Hash256) -> Result<(), Error> { | ||
| match self.db.remove(&key) { |
There was a problem hiding this comment.
Let's use https://doc.rust-lang.org/std/option/enum.Option.html#method.ok_or for the simplicity
There was a problem hiding this comment.
Cannot implement using ok_or since HashMap::remove returns Option<Vec<u8>>
kv-storage/src/memory.rs
Outdated
|
|
||
| async fn revert_to_latest_checkpoint(&mut self) -> Result<(), Error> { | ||
| self.db = self.checkpoint.clone(); | ||
|
|
kv-storage/src/memory.rs
Outdated
|
|
||
| async fn insert_or_update(&mut self, key: Hash256, value: &[u8]) -> Result<(), Error> { | ||
| self.db.insert(key, value.to_vec()); | ||
|
|
fakedev9999
force-pushed
the
feature/inmemorykvstorage
branch
from
cf0c1f1
to
c156993
Compare
junha1
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58