Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add playwright to simulator-ui #45

Closed
wants to merge 4 commits into from
Closed

Conversation

Jakoshi45
Copy link

No description provided.

@Jakoshi45
Copy link
Author

@bbortt @novarx

@Jakoshi45
Copy link
Author

not sure why there's so much stuff removed from package-lock.json. npm install didn't work for me, so maybe that's why?

@Jakoshi45
Copy link
Author

the tests are far from done, but I'm switching workplace.
Playwright is also supposed to execute through the pipeline on every branch. That works, but for some reason my 'npm i' commands throw errors, so I can't be sure if it works properly.

simulator ui playwright npm i errors

@@ -116,7 +116,9 @@ Desktop.ini
.eslintcache

######################
# Code coverage
# Test results
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Test results
# Test artefacts

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Kommentare, welche nicht unbedingt notwendig sind, können gelöscht werden.

test('should have total, successful, failed tabs', async ({page}) => {
await page.goto('http://localhost:9000/');

await expect(page.getByText('Total:')).toBeVisible();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diese Selektoren können noch etwas präziser sein.


test('total, successful, failed tabs should display percentage in simulations count', async ({page}) => {
await page.route('*/**/api/test-results/count-by-status', async route => {
const json = {"successful": 746039, "failed": 490, "total": 746529};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier könnten noch etwas einfachere Zahlen verwendet werden.

test('should click Details button', async ({page}) => {
await page.goto('http://localhost:9000/scenario-result/');

await expect(page.getByText('Items per Page')).toBeVisible();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dieser Test sollte noch erweitert oder in den nächsten integriert werden.

await expect(page).toHaveTitle(/Citrus Simulator/);
});

test('should have refresh list, and reset button', async ({page}) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dieser und der nächste Test können zusammengeführt werden.

@bbortt
Copy link
Member

bbortt commented Sep 13, 2024

superseded by #46.

@bbortt bbortt closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants