Skip to content

Commit

Permalink
refactor!: remove kubenurse_request_duration histogram
Browse files Browse the repository at this point in the history
is completely redundant with the httpclient_request_duration_seconds
histogram, which is now also partitioned by request type

[skip ci]

Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
  • Loading branch information
clementnuss committed Apr 11, 2024
1 parent 852ab85 commit 3061b64
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions internal/servicecheck/servicecheck.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,6 @@ func New(_ context.Context, cl client.Client, promRegistry *prometheus.Registry,
[]string{"type"},
)

durationHistogram := prometheus.NewHistogramVec(
prometheus.HistogramOpts{
Namespace: MetricsNamespace,
Name: "request_duration",
Help: "Kubenurse request duration partitioned by target path",
Buckets: durationHistogramBuckets,
},
[]string{"type"},
)

promRegistry.MustRegister(errorCounter, durationHistogram)

// setup http transport
tlsConfig, err := generateTLSConfig(os.Getenv("KUBENURSE_EXTRA_CA"))
if err != nil {
Expand Down

0 comments on commit 3061b64

Please sign in to comment.