Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching with controller-runtime client #112

Merged
merged 4 commits into from
Feb 20, 2024
Merged

caching with controller-runtime client #112

merged 4 commits into from
Feb 20, 2024

Conversation

clementnuss
Copy link
Contributor

No description provided.

permits to get rid of kubediscovery package and to simplify the codebase

linked to: #55

Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
closes #110

Signed-off-by: Clément Nussbaumer <clement.nussbaumer@postfinance.ch>
@clementnuss clementnuss marked this pull request as ready for review February 19, 2024 13:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7960550382

Details

  • -9 of 59 (84.75%) changed or added relevant lines in 4 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.6%) to 69.147%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/kubenurse/handler.go 5 6 83.33%
internal/servicecheck/neighbours.go 40 48 83.33%
Files with Coverage Reduction New Missed Lines %
internal/kubenurse/handler.go 14 63.83%
Totals Coverage Status
Change from base Build 7878059631: -4.6%
Covered Lines: 381
Relevant Lines: 551

💛 - Coveralls

@clementnuss clementnuss merged commit c3342f1 into master Feb 20, 2024
12 checks passed
@clementnuss clementnuss deleted the cjmn-patch-05e2 branch April 5, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants