Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup in admin command #126

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Minor cleanup in admin command #126

merged 3 commits into from
Aug 16, 2022

Conversation

chhetripradeep
Copy link
Contributor

Moved from if-else to match.

levkk
levkk approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@levkk levkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for constantly breaking the Docker config...we should probably just merge them at some point.

levkk
levkk reviewed Aug 16, 2022
View reviewed changes
src/admin.rs
ignore_set(stream).await
}
"SHOW" => match query_parts[1] {
"CONFIG" => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question: will this work if we pass in SHOW CONFIG;? I believe query_parts[1] will be CONFIG; which won't match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. It will not work.

@levkk levkk merged commit d64f679 into postgresml:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkk levkk levkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chhetripradeep @levkk