Patch graceful shutdown bug #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hutdown timeout is reached
levkk
reviewed
Sep 5, 2022
| @@ -204,7 +204,7 @@ pub async fn client_entrypoint( | |||
| Ok(mut client) => { | |||
| info!("Client {:?} connected (plain)", addr); | |||
|
|
|||
| if client.is_admin() { | |||
| if !client.is_admin() { | |||
There was a problem hiding this comment.
This is the opposite of what we're doing now. Could you describe the bug you're seeing?
There was a problem hiding this comment.
Recreating the bug.
Start pgcat.
Create client with sslmode disabled, ?sslmode=disable
execute single query then close connection.
Send sigint to pgcat
pgcat will want to wait for shutdown timeout
There was a problem hiding this comment.
this is actually most likely a typo since in every other case we're doing !client.is_admin()
There was a problem hiding this comment.
You're right, very nice find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes graceful shutdown bug for startup and cancel type ClientConnectionTypes
Adds logging for active clients when shutting down