Skip to content

Better logging for failure to get connection from pool #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

drdrsh
Copy link
Collaborator

@drdrsh drdrsh commented Sep 7, 2022

Current logging does not tell us which pool we failed to acquired a connection from. This PR adds more useful information to the logs

Could not get connection from pool: { pool_name: "sharded_db", username: "sharding_user", shard: 0, role: "None", error: "AllServersDown" }

@levkk levkk merged commit 744cead into postgresml:main Sep 7, 2022
jmeagher pushed a commit to jmeagher/pgcat that referenced this pull request Feb 17, 2023
Avoid reporting ProtocolSyncError when admin session disconnects (postgresml#160)
Better logging for failure to get connection from pool (postgresml#161)
Send signal even if process is gone (postgresml#162)
Clean connection state up after protocol named prepared statement (postgresml#163)
Add Discord link (postgresml#164)
Add SHOW CLIENTS / SHOW SERVERS + Stats refactor and tests (postgresml#159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants